Daniel Shahaf wrote: >> + * @deprecated Provided for backward compatibility with the 1.8 API. >> * @since New in 1.8. >> */ >> +SVN_DEPRECATED >> svn_error_t * >> svn_client_diff6(const apr_array_header_t *diff_options, > > Since this API is new in 1.8, you should just extend it without > deprecating it. > > (We only deprecate released APIs. svn_client_diff5 is released and set > in stone (save for certain const-ness and pointed-to structs changes, > maybe); svn_client_diff6 has not been released and can be modified > arbitrarily. (but those changes should be added to the "SVN 1.8 APIs > review" wiki page))
In principle, what Daniel states is correct, but in practice we're intending to branch 1.8 tomorrow, so this work is destined for 1.9, so leave that as it is (and change your new functions to say "New in 1.9."). - Julian
