Bert, I have some questions about the new svn_auth_cleanup_walk() API you introduced in trunk.
First, I see that the function drives a new cleanup callback function. That functions has parameters named 'cred_kind' and 'provider'. Now, my understanding is that 'cred_kind' is one of the credential type string identifies we use through the svn_auth code -- "svn.simple", "svn.username", etc. 'provider', I think, is going to name one of our third-party storage providers -- "gnome_keyring", "keychain", "windows", etc. When I read the implementation of this function -- and specifically the svn_auth__simple_cleanup_walk() function that really does all the work -- I see this cleanup callback called with a cred_kind argument but with the provider always as SVN_AUTH_CRED_SIMPLE -- which is a cred_kind value! Another question: it appears that we disallow cleanup of creds when 'no-auth-cache' is set. I should think that's one of the key times when a user would *want* to clean out existing cached authn creds. But maybe I'm missing something here. -- C. Michael Pilato <cmpil...@collab.net> CollabNet <> www.collab.net <> Enterprise Cloud Development
signature.asc
Description: OpenPGP digital signature