Hi Gabriela.

Gabriela Gibson wrote:

> I've made some changes to meet some feature requests regarding svn diff.
> 
> Could you please take a look and let me know if I'm on the right track?

> [[[
> Change "svn diff" to allow removal of "-u" and use of 
> arbitrary strings in place of current hard-coded "-L" switch.  This
> partially resolves.
> http://subversion.tigris.org/issues/show_bug.cgi?id=2044

For the record, the summary line of issue #2044 is 'Fully customizable external 
diff invocations'.  (I like to mention the summary alongside the number as I am 
not good at memorizing issue numbers.)  I'm curious about your patch because I 
am interested in issue #2044 and would like to see how this particular 
change would fit in.

Please could you tell me more precisely what your patch does and why?  Of 
course I could read carefully through your patch to discover the 'what', but 
not the 'why'.

Thanks.

- Julian


> 
> * subversion/svn/cl.h
>   (svn_cl__opt_state_t) Add two new fields.
> 
> * subversion/svn/svn.c
>   (svn_cl__longopt_t) Add new field.
>   (svn_cl__options) Add new field and help information.
>   (svn_cl__cmd_table) Add two new parameters.
>   (sub_main) Initialize new field.
>   (sub_main) Add new case.
>   (sub_main) Add conditional call to svn_config_set.
> 
> * subversion/svn/diff-cmd.c
>   (svn_cl__diff) Add braces and minor indentation issue?
>   (svn_cl__diff) Change call to svn_client_diff6 to svn_client_diff7.
> 
> * subversion/include/svn_config.h
>   () Add new declarations.
> 
> * subversion/include/svn_io.h
>   (svn_io_run_diff2_2) Add new function.
> 
> * subversion/include/svn_client.h
>   (svn_client_blame) Add new function. svn_client_diff7.
> 
> * subversion/libsvn_client/diff.c
>   (diff_cmd_baton) Add new field.
>   (diff_content_changed) Replace call to svn_io_run_diff2 with
>     svn_io_run_diff2_2.
>   (svn_client_diff7) Add new function.
> 
> * subversion/libsvn_subr/io.c
>   (svn_io_run_diff2_2) Add new function.
> 
> ]]]
>

Reply via email to