On 14 March 2013 16:09, Bert Huijben <b...@qqmail.nl> wrote:
>
>
>> -----Original Message-----
>> From: Sergei Antonov [mailto:sap...@gmail.com]
>> Sent: donderdag 14 maart 2013 16:02
>> To: dev@subversion.apache.org
>> Subject: Re: Windows build still requires apr-util?
>>
>> On 14 March 2013 15:00, Bert Huijben <b...@qqmail.nl> wrote:
>> >
>> >
>> >> -----Original Message-----
>> >> From: Sergei Antonov [mailto:sap...@gmail.com]
>> >> Sent: donderdag 14 maart 2013 14:13
>> >> To: Bert Huijben
>> >> Subject: Re: Windows build still requires apr-util?
>> >>
>> >> On 14 March 2013 13:44, Bert Huijben <b...@qqmail.nl> wrote:
>> >> >
>> >> >
>> >> >> -----Original Message-----
>> >> >> From: Sergei Antonov [mailto:sap...@gmail.com]
>> >> >> Sent: donderdag 14 maart 2013 13:31
>> >> >> To: Bert Huijben
>> >> >> Subject: Re: Windows build still requires apr-util?
>> >> >>
>> >> >> On 13 March 2013 19:15, Bert Huijben <b...@qqmail.nl> wrote:
>> >> >> >
>> >> >> >
>> >> >> >> -----Original Message-----
>> >> >> >> From: Sergei Antonov [mailto:sap...@gmail.com]
>> >> >> >> Sent: woensdag 13 maart 2013 18:47
>> >> >> >> To: dev@subversion.apache.org
>> >> >> >> Subject: Re: Windows build still requires apr-util?
>> >> >> >>
>> >> >> >> Gentle reminder: VS 2010 doesn't compile the latest revision.
>> >> >> >> Please, add "#include <time.h>" into
>> >> >> >> subversion\libsvn_subr\win32_crashrpt.c and commit.
>> >> >> >
>> >> >> > I think that is somehow dependant on other settings as it just
>> compiles
>> >> for
>> >> >> me with 2010 (and 2012 and 2008).
>> >> >>
>> >> >> Do not compile this file at all?
>> >> >>
>> >> >> > Can you explain what makes your environment different
>> >> >>
>> >> >> You do not have SVN_USE_WIN32_CRASHHANDLER?
>> >> >> You use different revision? (mine is 1456399)
>> >> >>
>> >> >> Open VS 2010 .sln, navigate to 'win32_crashrpt.c' in project
>> >> >> 'libsvn_subr', choose Build->Compile. What do you see? I see this:
>> >> >
>> >> > I use the crash handler. (Standard settings) and I usually build
>> Subversion
>> >> trunk multiple times per day with different Visual Studio versions. The
>> >> file
>> >> hasn't changed in this respect for years.
>> >> >
>> >> > time.h is included by apr.h for me.
>> >>
>> >> My apr.h is attached. Can you compare it with yours?
>> >>
>> >> > I don't see why we would have to duplicate the include here in my
>> >> environment.
>> >>
>> >> Is time.h from apr.h guaranteed?
>> >
>> > Yes
>>
>> Hard to believe. I don't know about apr specifically, but usually
>> library headers (like apr.h) are means to deliver library's (i.e.
>> APR's) functions/types/constants and not means to deliver system
>> headers. And when they do, it is just a side effect.
>>
>> > We don't declare apr 2.X support in Subversion, so I would guess that is
>> untested.
>>
>> Didn't know about not supporting 2.X in subversion. Thanks for
>> telling. It is not mentioned in 'INSTALL'.
>
> From the details section of INSTALL
>>>>>
> 1. Apache Portable Runtime 0.9.7 or 1.X.X (REQUIRED)
>
> Whenever you want to build any part of Subversion, you need the
> Apache Portable Runtime (APR) and the APR Utility (APR-util)
> libraries.
> <<<<
I compiled for Windows, so I went straight to "E. Building the Latest
Source under Windows" of INSTALL, and read there:
* Apache apr, apr-util, and optionally apr-iconv libraries, version
0.9.12 or later. Included in both the Subversion dependencies ZIP file
"or later" - no upper limit.
> Also note that there are no released apr 2.x versions on
> http://apr.apache.org/, the recommended version there is still 1.4.6.
Good. I've switched to 1.4.6.
