Hi, On Sun, Dec 2, 2012 at 3:18 PM, Justin Erenkrantz <jus...@erenkrantz.com> wrote: > On Sun, Dec 2, 2012 at 9:05 AM, Lieven Govaerts <svn...@mobsol.be> wrote: >> >> Attached the patch. ( I get paid per mail I send to this list in case >> no one noticed. ;) ) > > > The patch looks right to me - the short-circuit to do the simple window can > clearly be called for any window regardless of offset. Perhaps we can add > this testcase to the regression tests as well? > > As for the looping, didn't we put in logic to stop retrying after a number > of request failures? That's probably a reasonable thing to do...I > definitely think a very nice feature of serf is that it *will* retry (which > is helpful in flaky network situations), but it needs to stop at a certain > point. =) -- justin
Serf is resending requests that were waiting on the pipeline to be handled by the server, but when a read error is received it will not resend the request. Maybe ra_serf is doing that in some situations, but I don't think so either. The issue here is that serf trunk was ignoring a read error on the connection with an outstanding request, as a side effect if r1695. That has been fixed in r1696. Lieven
