> -----Original Message-----
> From: julianf...@apache.org [mailto:julianf...@apache.org]
> Sent: woensdag 21 november 2012 02:27
> To: comm...@subversion.apache.org
> Subject: svn commit: r1411971 -
> /subversion/trunk/subversion/svnlook/main.c
>
> Author: julianfoad
> Date: Wed Nov 21 01:26:35 2012
> New Revision: 1411971
>
> URL: http://svn.apache.org/viewvc?rev=1411971&view=rev
> Log:
> Fix a stdout handling problem in 'svnlook diff', which may be causing the
> Windows
> test failures that started with r1411948.
>
> * subversion/svnlook/main.c
> (display_prop_diffs): Close the stream to stdout before flushing stdout and
> returning.
>
> Modified:
> subversion/trunk/subversion/svnlook/main.c
>
> Modified: subversion/trunk/subversion/svnlook/main.c
> URL:
> http://svn.apache.org/viewvc/subversion/trunk/subversion/svnlook/main.c
> ?rev=1411971&r1=1411970&r2=1411971&view=diff
> ==========================================================
> ====================
> --- subversion/trunk/subversion/svnlook/main.c (original)
> +++ subversion/trunk/subversion/svnlook/main.c Wed Nov 21 01:26:35 2012
> @@ -933,6 +933,7 @@ display_prop_diffs(const apr_array_heade
> }
> svn_pool_destroy(iterpool);
>
> + SVN_ERR(svn_stream_close(outstream));
The output stream is a disowned wrapper around the apr stream for stdout, so
this function call performs exactly nothing.
I would recommend removing this call, as this might make somebody think that we
close stdout, which is something completely else. (And in that case flushing it
after closing would be a real error)
Bert
> return svn_cmdline_fflush(stdout);
> }
>
>
