Julian Foad <julianf...@btopenworld.com> writes: >> Author: cmpilato > >> >> URL: http://svn.apache.org/viewvc?rev=1411671&view=rev >> Log: >> Minor logic simplification. >> >> * subversion/libsvn_ra_serf/serf.c >> (load_config): Simplify timeout calculations, since we know >> DEFAULT_HTTP_TIMEOUT is non-negative and we know the >> get-time-from-config path errors out on negative values. > > Oops -- that logic was there to catch the fact that the default 3600 seconds > goes negative in the 32-bit variable it's assigned to. > > It's stupid and backwards for at least two reasons. > > 1) Bert says on IRC, "The timeout value in neon was used for a > completely different purpose: In neon: complete request timeout, in > serf: chunk received timeout. Default http timeout is 30 or 60 > minutes. A bit long for waiting for a tcp segment."
This value is also affected by the http-timeout setting in .subversion/servers which means users may have customised it. If it means something different for serf should we introduce a new constant and new config setting? -- Certified & Supported Apache Subversion Downloads: http://www.wandisco.com/subversion/download
