On Fri, Nov 02, 2012 at 12:22:29PM +0100, Bert Huijben wrote: > Can you please use a specific error code if an upgrade is required? > (SVN_ERR_WC_UPGRADE_REQUIRED or a new error?) > > GUI clients can't just parse the textual output of error messages, and want > to parse the error code. > > SVN_ERR_WC_NOT_WORKING_COPY has a different handling for those clients than > suggesting the user to upgrade.
We can do this, yes. It's a matter of hunting down the code that returns the NOT_WORKING_COPY error and replacing or wrapping the error with UPGRADE_REQUIRED where appropriate. FWIW, I tried my best not to change existing error codes that were returned before my change, and I added errors other than UPGRADE_REQUIRED only in the 'upgrade' code path itself. So I believe this is not new behaviour I introduced. It's just that we need to additionally make error reporting smarter than it used to be.
