In several places in ra_serf I see the pattern:
/* Skip on to the next iteration of this loop. */
if (APR_STATUS_IS_EAGAIN(status))
{
return svn_ra_serf__wrap_err(status, NULL);
}
continue;
Is that test correct? It causes EAGAIN to be returned and any other
error to continue the loop which seems to contradict the comment. I
suppose EAGAIN could be handled at some higher level but simply
continuing on all other errors looks wrong.
--
Certified & Supported Apache Subversion Downloads:
http://www.wandisco.com/subversion/download
