On Wed, Oct 10, 2012 at 7:09 PM, Stefan Fuhrmann <stefan.fuhrm...@wandisco.com> wrote: > On Tue, Oct 9, 2012 at 10:19 PM, Johan Corveleyn <jcor...@gmail.com> wrote: >> >> I haven't built trunk in a couple of weeks. I'm catching up now, and I >> see a lot of new warnings coming from fsfs-reorg.c (compiled with >> Visual C Express 2008 on WinXP). Stefan (or anyone else), can you take >> a look at these? > > > Yes, I can. But maybe not before the weekend. > As long as your repository does not contain pack > files > 4GB, you should be safe. If it does, > changes are that you will run out of memory > on that repo anyway ;)
Ah yes, especially on my 32-bit system :-). There's no rush, I just noticed the warnings and felt the urge to report them :-) ... > BTW, that code is not supposed to be *ever* > used for production data. Ok, good to know. I just executed the tool and saw the prominent warning, so that's pretty clear. [ ... ] > Would be nice if people could use it to test / > evaluate the results. The hole idea is to verify > the method before attempting significant changes > to the FSFS layer in 1.9. Can you summarize a bit (maybe you explained it already in some notes file, but I don't quite remember) what it does again? What's the goal really? Is it about reshuffling the data inside the pack files to be more I/O efficient, while maintaining compatibility with existing servers (so a reorg'ed repository can be read by any 1.x server)? If so, how does it do that actually? And, if we're thinking about evaluating the results: what should one focus on? Any particular use cases that should get a significant positive effect? Any use cases that might possibly be negatively affected? -- Johan
