On Wed, Sep 19, 2012 at 6:24 PM, Ivan Zhakov <i...@visualsvn.com> wrote:
> On Wed, Sep 19, 2012 at 6:06 PM, Philip Martin
> <philip.mar...@wandisco.com> wrote:
>> Ivan Zhakov <i...@visualsvn.com> writes:
>>
>>> -get_access_conf(request_rec *r, authz_svn_config_rec *conf)
>>> +get_access_conf(request_rec *r, authz_svn_config_rec *conf, apr_pool_t
>>> *scratch_pool)
>>
>> That line is longer than 80 characters.
>>
>>> +subreq_bypass2(request_rec *r,
>>> + const char *repos_path,
>>> + const char *repos_name,
>>> + apr_pool_t *scratch_pool)
>>> {
>>> svn_error_t *svn_err = NULL;
>>> svn_authz_t *access_conf = NULL;
>>> @@ -595,7 +597,7 @@
>>>
>>> conf = ap_get_module_config(r->per_dir_config,
>>> &authz_svn_module);
>>> - username_to_authorize = get_username_to_authorize(r, conf);
>>> + username_to_authorize = get_username_to_authorize(r, conf, scratch_pool);
>>>
>>> /* If configured properly, this should never be true, but just in case.
>>> */
>>> if (!conf->anonymous
>>> @@ -606,7 +608,7 @@
>>> }
>>>
>>> /* Retrieve authorization file */
>>> - access_conf = get_access_conf(r, conf);
>>> + access_conf = get_access_conf(r, conf, scratch_pool);
>>> if (access_conf == NULL)
>>> return HTTP_FORBIDDEN;
>>>
>>
>> The call svn_repos_authz_check_access needs to be changed to pass
>> scratch_pool.
>>
> Oops, I need commit more often :) See updated patch.
>
Commited in r1387943.
--
Ivan Zhakov
