On 10.09.2012 23:49, Daniel Shahaf wrote:
> br...@apache.org wrote on Mon, Sep 10, 2012 at 17:19:32 -0000:
>> Author: brane
>> Date: Mon Sep 10 17:19:31 2012
>> New Revision: 1382990
>>
>> URL: http://svn.apache.org/viewvc?rev=1382990&view=rev
>> Log:
>> Make the extended version info retrieval a public API.
>>
>> +/**
>> + * Extended version infomation, including info about the running system.
>> + *
>> + * @since New in 1.8.
>> + */
> Are we going to extend the struct in future releases? If so, do we want
> constructor/duplicator functions?
Maybe. If we do, we probably want to make the type completely opaque anyway.
svn_version_extended is effectively a constructor, since it's the only
function that allocates such a struct.
>> +typedef struct svn_version_extended_t
>> +{
>> + const char *version_number; /**< Version number */
>> + const char *version_string; /**< Version string */
>> + const char *build_date; /**< Compilation date */
>> + const char *build_time; /**< Compilation time */
>> + const char *build_host; /**< Build canonical host name */
>> + const char *copyright; /**< Copyright notice (localized) */
>> + const char *runtime_host; /**< Runtime canonical host name */
>> + const char *runtime_osname; /**< Running OS release name */
>> +
>> + /**
>> + * Array svn_version_linked_lib_t describing dependent libraries.
>> + */
>> + const apr_array_header_t *linked_libs;
>> +
>> + /**
>> + * Array of svn_version_loaded_lib_t describing loaded shared libraries.
>> + */
>> + const apr_array_header_t *loaded_libs;
> Please document the type ('const char *' ? ) of array elements.
Um, it says "Array of svn_version_(linked|loaded)_lib_t", which are
defined a few lines lower down in the file. What should I add to the
docstring?
-- Brane
--
Certified & Supported Apache Subversion Downloads:
http://www.wandisco.com/subversion/download
