phi...@apache.org writes: > Author: philip > Date: Mon Sep 3 08:59:54 2012 > New Revision: 1380175 > > URL: http://svn.apache.org/viewvc?rev=1380175&view=rev > Log: > Followup to r1242759 which removed the explicit D-Bus calls from the > GNOME keyring code. D-Bus is still used but it's all in the external > libgnome-keyring. > > * configure.ac: (gnome_keyring) Don't require D-Bus. > > * subversion/libsvn_auth_gnome_keyring/gnome_keyring.c (): Remove include.
The D-Bus calls were first removed from the keyring code in r873192 but that removal was reverted in r873256 due to run-time warning/error messages. I wasn't aware of this history when I committed r1242759 and I don't see the run-time problems with the current code. Perhaps r878952 removed the problem or perhaps GNOME has changed. D-Bus seems to be necessary at run-time with the current gnome keyring on Linux as I need to do both: eval `dbus-launch --sh-syntax` export `gnome-keyring-daemon` to use the keyring in an ssh session, but D-Bus does not need to be a compile time dependency. I don't know the full history but in the past libgnome-keyring was able to communicate with the daemon without D-Bus running or even being present on the machine (on old Solaris at least). -- Philip
