Роман Донченко <d...@corrigendum.ru> writes: > - On Windows, we only support linking with svn-win32-libintl, which is > hacked to disable all encoding conversions.
I assume it provides bind_textdomain_codeset as a function that does nothing. > - Even if someone links with with his own version of libintl, it's a > safe bet that it will be new enough to support > bind_textdomain_codeset, so we can just call that. If somebody managed to use an old version I guess there would be some sort of linker failure. Build time? Run time? If somebody managed to use their own version that did encoding conversions I guess that would also be OK since it would be a utf8-utf8 no-op. The patch looks OK but I don't know enough about the Windows build to know whether the above is correct. -- Certified & Supported Apache Subversion Downloads: http://www.wandisco.com/subversion/download
