On Tue, Jul 10, 2012 at 6:34 PM, Philip Martin <philip.mar...@wandisco.com>wrote:
> Stefan Fuhrmann <stefan.fuhrm...@wandisco.com> writes: > > > On Tue, Jul 10, 2012 at 1:15 PM, Philip Martin > > <philip.mar...@wandisco.com>wrote: > > > >> stef...@apache.org writes: > >> > >> > Author: stefan2 > >> > Date: Tue Jul 10 10:19:42 2012 > >> > New Revision: 1359574 > >> > >> > + else > >> > + right_size += APR_ARRAY_IDX(revprops->sizes, right--, > >> apr_off_t); > >> > + + SVN_INT64_BUFFER_SIZE; > >> > >> ../src/subversion/libsvn_fs_fs/fs_fs.c: In function > ‘write_packed_revprop’: > >> ../src/subversion/libsvn_fs_fs/fs_fs.c:4018: warning: statement with no > >> effect > >> > > > > D'oh! > > > > > >> Also, putting right-- in a macro like APR_ARRAY_IDX relies on the macro > >> not expanding to use the parameter twice. > >> > > > > Thanks for the review! > > Fixed in r1359753. > > I'm seeing fs-pack-test 6 failing. > > $ ./fs-pack-test 6 > ../src/subversion/tests/svn_test_main.c:275: (apr_err=200006) > svn_tests: E200006: Test crashed (run in debugger with '--allow-segfaults') > FAIL: lt-fs-pack-test 6: get/set large packed revprops in FSFS > *Sigh* Fixed in r1359771. Note to self: always, *always* run tests before comitting ... -- Stefan^2. -- Certified & Supported Apache Subversion Downloads: http://www.wandisco.com/subversion/download
