On Jun 30, 2012 7:00 AM, <rhuij...@apache.org> wrote:
>...
> @@ -627,6 +630,33 @@ svn_wc__conflict_read_info(svn_wc_operat
>   else if (locations)
>     *locations = NULL;
>
> +  if (text_conflicted)
> +    {
> +      svn_skel_t *c_skel;
> +      SVN_ERR(conflict__get_conflict(&c_skel, conflict_skel,
> +                                     SVN_WC__CONFLICT_KIND_TEXT));
> +
> +      *text_conflicted = (c_skel != NULL);
> +    }
> +
> +  if (prop_conflicted)
> +    {
> +      svn_skel_t *c_skel;
> +      SVN_ERR(conflict__get_conflict(&c_skel, conflict_skel,
> +                                     SVN_WC__CONFLICT_KIND_PROP));
> +
> +      *prop_conflicted = (c_skel != NULL);
> +    }
> +
> +  if (tree_conflicted)
> +    {
> +      svn_skel_t *c_skel;
> +      SVN_ERR(conflict__get_conflict(&c_skel, conflict_skel,
> +                                     SVN_WC__CONFLICT_KIND_TREE));
> +
> +      *tree_conflicted = (c_skel != NULL);
> +    }

Seriously? Maybe I need a macro to ease my reviews:

const!

>...

(and to repeat my request for blank lines between declarations and code;
those are separate semantic items, and should have visible separation)

Cheers,
-g

Reply via email to