> -----Original Message----- > From: Greg Stein [mailto:gst...@gmail.com] > Sent: dinsdag 5 juni 2012 17:11 > To: dev@subversion.apache.org > Subject: Re: svn commit: r1346352 - in > /subversion/trunk/subversion/libsvn_wc: questions.c wc_db.c wc_db.h > workqueue.c > > On Tue, Jun 5, 2012 at 7:31 AM, <rhuij...@apache.org> wrote: > > Author: rhuijben > > Date: Tue Jun 5 11:31:17 2012 > > New Revision: 1346352 > > > > URL: http://svn.apache.org/viewvc?rev=1346352&view=rev > > Log: > > Revert r1346035, which exposed op_depth to more of the libsvn_wc api > than > > really necessary in preparation for a cleaner and even more optimized > version. > > Thanks. Sounds like you have a new idea?
The only case that really needs optimization would be op_depth 0, called from the working queue install operation. That could be expressed by a Boolean instead of an int. But it would be much cleaner to move most of that code in a new svn_wc__db_pristine api, which would also allow using a db read lock to get even higher performance during checkout and update. Bert