On Mon, Jun 4, 2012 at 2:34 PM, Peter Samuelson <pe...@p12n.org> wrote: > > [stef...@apache.org] >> Minor svn: latency improvement: call dcgettext for error messages >> only if an error actually occurred. >> >> * subversion/libsvn_ra_svn/client.c >> (handle_unsupported_cmd): translate message here ... >> (ra_svn_stat, ra_svn_get_locations, ra_svn_get_location_segments, >> ra_svn_get_file_revs, ra_svn_lock_compat, ra_svn_unlock_compat, >> ra_svn_get_lock, ra_svn_get_locks, ra_svn_replay, >> ra_svn_replay_range, ra_svn_get_deleted_rev): ... instead of here > > Wait ... does this work? Are all the strings still extracted for > translation? I thought po-update.sh had to rely on source-level hints > like _() to find the strings to extract.
Yeah... that won't work. The strings need to be marked. Documentation for macro conventions is horrible. Couldn't find a good page for gettext itself, but I found this from Gnome: http://developer.gnome.org/glib/stable/glib-I18N.html The N_() macro will mark the string for translation, but will not invoke dgettext(). That is what Stefan wants to use. (and I need to go undo some of my uses of that; I believed it was "I'm specifically noting this isn't for translation, rather than forgetting to wrap the string in _()") Cheers, -g
