On May 31, 2012 11:07 PM, "Vladimir Berezniker" <v...@hitechman.com> wrote: > On Thu, May 31, 2012 at 3:35 AM, Greg Stein <gst...@gmail.com> wrote: >>... >> (sorry, but the patch doesn't inline into this response, so let's just >> be flexible here...) >> > Sorry, I cannot figure out how to get gmail to inline attachments, I'll setup > IMAP client when I have a spare moment to to figure out which one will > work for me.
Oh, attachments are best because they don't get munged in various ways. It was just that I was on my tablet (now, too), and it is near impossible to get the attachments into the body. *shrug* >> The macro argument substitutions need to be parenthesized for safety. >> So it would be: (expr) == NULL, and it would be: return (ret_val); > > > will take care of (expr). Same cannot be done for ret_val because it is > valid for the ret_val to be empty when used inside void methods. Saw that, yeah. >... > I am a java guy, with a some C/C++ understanding, afraid I won't be of > much help in this department. Most of the macro is repeat of the existing > SVN_JNI_NULL_PTR_EX with different exception being thrown. No worries. Just curious. Cheers, -g
