On Sun, May 20, 2012 at 8:14 PM, <stef...@apache.org> wrote: >... > +++ subversion/trunk/subversion/libsvn_fs_fs/fs_fs.c Mon May 21 00:14:20 2012 >... > + const char *path; > + apr_ssize_t klen; > + apr_hash_this(hi, (const void **)&path, &klen, NULL);
Historically, we have not allowed casts like this. Please switch the PATH localvar to void* and drop the cast. The rest of the function will work fine with path as a void*. > + > + /* If we come across a child of our path, remove it. > + Call svn_dirent_is_child only if there is a chance that > + this is actually a sub-path. > + */ > + if ( klen >= min_child_len > + && svn_dirent_is_child(change->path, path, iterpool)) > apr_hash_set(changed_paths, path, klen, NULL); > } > } Cheers, -g
