On Mon, May 14, 2012 at 3:12 PM, <s...@apache.org> wrote: > Author: stsp > Date: Mon May 14 19:12:13 2012 > New Revision: 1338350 > > URL: http://svn.apache.org/viewvc?rev=1338350&view=rev > Log: > Use svn_hash__make() instead of apr_hash_make() in select places to ensure > stable ordering of output. This commit makes the output of 'svn status' > and 'svn proplist' stable.
I think you're solving this at the wrong level. Why should the functions below care about stable ordering? These are hash tables, which *by definition* are "unordered". With these changes, you're affecting *all* users rather than just the places that are important. If you want stable ordering, then at some higher level _where ordering matters_, get an array of sorted keys and walk the hash table that way. I'm somewhere between -0.5 and -1 on this commit. I feel pretty strongly that this is not a correct solution. Thanks, -g
