On May 14, 2012 3:50 AM, "C. Michael Pilato" <cmpil...@collab.net> wrote: > > On 05/11/2012 05:40 PM, gst...@apache.org wrote: > > Author: gstein > > Date: Fri May 11 21:40:55 2012 > > New Revision: 1337388 > > > > URL: http://svn.apache.org/viewvc?rev=1337388&view=rev > > Log: > > Note a problem. The new xml parsers should correct issues like this. > > > > * subversion/libsvn_ra_serf/get_deleted_rev.c: > > (cdata_getdrev): this function could be invoked N times with a > > single character of the revision. the approach used here is wrong. > > leave a marker noting that. > > ... and these aren't merely theoretical problems -- I've run into several > real-world incidences of this sort before. Need to use a stringbuf to > collect all the CDATA, and transfer to the preferred storage location/format > in the end-tag handler.
Yup, exactly! The new code does this properly and automagically, so we won't see these odd one-off errors. This specific code has already been upgraded. Cheers, -g
