Greg Stein wrote:
On Thu, May 3, 2012 at 3:16 AM,<stef...@apache.org> wrote:
Author: stefan2
Date: Thu May 3 07:16:11 2012
New Revision: 1333326
URL: http://svn.apache.org/viewvc?rev=1333326&view=rev
Log:
Introduce private API functions that wrap apr_hash_make_custom
and return hash tables that are 2 to 4 times faster than the APR default.
Both yield repeatable results (each instance will store items in the same
order if the keys are the same). The first, svn_hask__make will return
a hash table that behaves like pre APR 1.4.6 default hashes.
* subversion/include/private/svn_hash_private.h
(svn_hash__make, svn_hash__make_fast): new private API
It would be great to just use svn_subr_private.h.
I've been mislead by svn_string_private.h & friends.
But having just one private header per lib definitely
makes more sense.
Moved in r1333340.
...
+++ subversion/trunk/subversion/libsvn_subr/hash.c Thu May 3 07:16:11 2012
...
+#if SVN_UNALIGNED_ACCESS_IS_OK
+# define READ_CHUNK(p)\
+ *(const apr_uint32_t *)(p);
erroneous trailing semicolon. this can stay on a single line, too.
Oops. Fixed in r1333354.
Thanks for the review!
-- Stefan^2.