On Mon, Apr 30, 2012 at 17:58, <hwri...@apache.org> wrote: >... > @@ -902,9 +956,13 @@ repos_to_repos_copy(const apr_array_head > message, ctx, pool)); > > /* Fetch RA commit editor. */ > - SVN_ERR(svn_ra__register_editor_shim_callbacks(ra_session, > - svn_client__get_shim_callbacks(ctx->wc_ctx, > - NULL, pool))); > + shim_callbacks = svn_delta_shim_callbacks_default(pool); > + SVN_ERR(svn_ra__register_editor_shim_callbacks(ra_session, > shim_callbacks)); > + shim_callbacks->fetch_props_func = fetch_props_func; > + shim_callbacks->fetch_base_func = fetch_base_func; > + shim_callbacks->fetch_kind_func = fetch_kind_func; > + shim_callbacks->fetch_baton = path_infos;
Shouldn't the registration occur *after* the values are assigned? I recognize that this "works", but it certainly looks strange, and it would definitely break if the structure is copied into RA-private storage. Cheers, -g
