Julian Foad <julianf...@btopenworld.com> writes: > Suggesting a docco improvement for svn_wc__db_scan_deletion(): > > --- Base (BASE) > +++ Locally Modified (Based On LOCAL) > @@ -2600,10 +2600,10 @@ > MOVED_TO_ABSPATH will specify the path where this node was moved to > if the node has moved-away. > > - If the node was moved-away, MOVED_TO_OP_ROOT_ABSPATH will specify the root > - of the copy operation that created the move destination. > - If LOCAL_ABSPATH itself is the root of the copy, MOVED_TO_OP_ROOT_ABSPATH > - equals MOVED_TO_ABSPATH. > + If the node was moved-away, MOVED_TO_OP_ROOT_ABSPATH will specify the > + target-root of the move operation. If LOCAL_ABSPATH itself is the > + source-root of the move, then MOVED_TO_OP_ROOT_ABSPATH equals > + MOVED_TO_ABSPATH. > > All OUT parameters may be set to NULL to indicate a lack of interest in > that piece of information. > > > > OK to commit? > > (There's more to do, but gotta start somewhere.)
I suppose it's better. To be honest I'm not sure exactly what this function is supposed to do with multi-layer-move, or whether what it does at the moment is correct. Consider: svn mv A/f A/g svn mv A B select op_depth, local_relpath, presence, moved_to, moved_here from nodes order by op_depth, local_relpath" 0||normal|| 0|A|normal|| 0|A/f|normal|| 1|A|base-deleted|B| 1|A/f|base-deleted|| 1|B|normal||1 1|B/f|normal||1 2|B/f|base-deleted|B/g|0 2|B/g|normal||1 What are MOVED_TO_ABSPATH and MOVED_TO_OP_ROOT_ABSPATH for A/f? -- uberSVN: Apache Subversion Made Easy http://www.uberSVN.com
