Stefan Fuhrmann wrote: > Julian Foad wrote: >> Please edit the log message for this rev. > Done for r1296596.
Hi Stefan. Thank you for removing "Found by: julianfoad", but also you should change the log message from the present "actually return MAX_LEN if MAX_LEN chars match." to something like "Add comments and re-write code for clarity. No functional change." as r1296596 caused no change in return values. >> (I assume you'll revisit this soon, as my original comment still >> stands. Sorry if it was confusing. What I meant, basically, is >> that the function doesn't return what the doc string says it will >> return, AFAICT. Quite likely it's the doc string that's wrong.) > > r1310770 should address that issue now. Yup, I agree that makes the function's doc string match its behaviour. Thanks. - Julian
