On Sun, Mar 25, 2012 at 13:16, Julian Foad <[email protected]> wrote: > Greg Stein wrote: >> [email protected] wrote: >>> Change the members of 'merge_source_t' from in-line to pointers. >>> A follow-up to r1303807. >> This says what you did, but I don't understand the justification for it. The >> code seems more complicated now (eg. the create/dup functions). >>?? > > > Good question. To be honest I was going on intuition here. The main aim is > to make it simple at the point of use; the complexity of the create/dup > functions is rather immaterial in comparison. The *existence* of the > 'create' and 'dup' functions would still be useful without this change. > > So, we ask, does this change make it easier to use? Actually it seems to be > neither simpler nor more complex. I can only say, this is fairly new and > still in flux.
More pointers mean more allocations and little fiddly bits to connect together. Embedded structures are easier to initialize. Cheers, -g
