On 03/13/2012 01:04 PM, Julian Foad wrote: > C. Michael Pilato wrote: >> On 03/13/2012 11:39 AM, julianf...@apache.org wrote: >>> * subversion/include/svn_repos.h >>> (svn_repos_fs_get_mergeinfo): Clarify that paths start with '/'. >> >> Explicitly mentioned the "fspath" term? >> >> The paths in @a paths, and the keys of @a catalog, are fspaths (that is, >> they start with '/'). >> >> Or perhaps mention the term, omit its parenthesized distinguishing feature, >> and just trust that our glossary penetration is good enough. >> >> There's no point in creating such terms if we don't use them. > > Sure, and also we could rename the parameter to 'prefix_fspath', since a > clue in the function prototype is even more helpful than in the doc > string.
Agreed! > But I also thought we might want to relax the function to allow either > fspaths or relpaths (maybe requiring the prefix kind to match the cat > keys kind, maybe not). Specifically, I've written some uncommitted code > which needs this function to be so relaxed, and also I noticed that the > complementary 'add_prefix' function seems to be so relaxed as well. > Didn't want to delay the commit because of such thoughts. Fair 'nuff. -- C. Michael Pilato <cmpil...@collab.net> CollabNet <> www.collab.net <> Distributed Development On Demand
signature.asc
Description: OpenPGP digital signature
