On Tue, Mar 13, 2012 at 8:45 AM, Greg Stein <gst...@gmail.com> wrote: > > On Mar 13, 2012 9:34 AM, "Hyrum K Wright" <hyrum.wri...@wandisco.com> wrote: >> >> On Tue, Mar 13, 2012 at 1:09 AM, Greg Stein <gst...@gmail.com> wrote: >> > On Tue, Mar 13, 2012 at 00:55, <hwri...@apache.org> wrote: >> >>... >> >> +++ subversion/trunk/subversion/tests/cmdline/svntest/main.py Tue Mar >> >> 13 04:55:26 2012 >> >> @@ -36,6 +36,7 @@ import optparse >> >> import xml >> >> import urllib >> >> import logging >> >> +import cStringIO as StringIO >> > >> > No need to rename this module, as is typical with back-compat importing. >> >> This isn't backward compat, it's an alternative implementation that is >> a drop-in replacement for the StringIO module, hence the desire to >> alias it. > > Dude. I *know* what it is. My point is that it is silly to rename it when it > has been a standard module for *years*. Nobody really uses StringIO any > more. It is all cStringIO, possibly renamed thru import logic that is used > for back-compat. The rename is superfluous gunk nowadays.
I've no doubt *you* know what it is, but this is a public list. And out test suite still uses vanilla StringIO, in both factory.py and tree.py (though I plan to change that shortly). This feels like a bikeshed, and I'll shortly do away with it by importing the StringIO class from $MODULE, as we do in other modules in our tree. -Hyrum -- uberSVN: Apache Subversion Made Easy http://www.uberSVN.com/
