On Mon, Mar 12, 2012 at 2:36 PM, Mark Phippard <markp...@gmail.com> wrote: > On Mon, Mar 12, 2012 at 9:31 AM, Hyrum K Wright > <hyrum.wri...@wandisco.com> wrote: > >> The primary issue when I looked at this problem was that the streamy >> abstraction is broken in several places, such as when we install the >> new pristine file. There are also certain consumers, such as a >> external diff tools, that require an uncompressed on-disk file to >> operate on, and we currently just provide the pristine as that file. >> Compressed pristines would require recreating the uncompressed version >> when such a tool is invoked. Whether this is a useful tradeoff, I >> don't know. > > When svn:eol-style keyword is set I thought the pristine was always > stored with LF line-endings? Wouldn't that "break" external diff > tools on Windows (which I do not think is the case today but maybe it > is).
I'm not sure it this is what you mean, but there is an open issue regarding wrong eol-style in diffs on Windows (but it's with the internal diff --- perhaps it just has the exact same problem as the one you're suggesting here for external diff tools): http://subversion.tigris.org/issues/show_bug.cgi?id=3338 (Inconsistent line endings when diffing svn:eol-style native file) (BTW: the pristine file (on Windows) only has LF line-endings when svn:eol-style=native (or =LF). When it's svn:eol-style=CRLF, the pristine file has CRLF (as does the file in the repository)) -- Johan
