On Fri, Mar 2, 2012 at 6:20 AM, C. Michael Pilato <cmpil...@collab.net> wrote: > On 03/02/2012 01:03 AM, Greg Stein wrote: >> On Fri, Mar 2, 2012 at 01:01, Greg Stein <gst...@gmail.com> wrote: >>> On Fri, Mar 2, 2012 at 00:47, Greg Stein <gst...@gmail.com> wrote: >>> Looking more into this, the shims should accept an "anchor_url" and if >>> they receive a URL in the copyfrom_path, then it should turn that URL >>> into a relpath from that anchor. And *then* invoke the callback. >>> >>> IOW, I think the original bug is that a URL is passed into >>> ev1->add_file(copyfrom_path). The shim should strip that down to a >>> relpath before invoking the callback. >> >> And replying to myself one more time... :-) >> >> Yes, I know that the delta editor spec allows a URL to be passed as >> that parameter. But I don't think we should propagate it into the >> callbacks. Messy.
I would welcome a cleaner handling of this, but as structured we just don't have enough information to generate a proper relpath from the URL that Ev1 senders give us. > Just to add, you know, a second voice to this already lengthy conversation > :-): that Ev1 add_file/dir allows URLs is definitely confusing at times. > The need for it is fairly obvious, though: sometimes you have to copy from > a location that's outside the edit tree, requiring either an absolute path > reference (such as a URL) or a relative path with '..' components. URLs > were the obvious first choice. > > If Ev2 can handle such cases without using URLs, +1 to barring their > introduction into the supported parameter set. Agreed, though I think the changes required to support such a paradigm will be much more intrusive than it may appear at first blush (and somewhat beyond the scope of what I'm trying to do *right now*). If somebody wants to jump in and tackle them, I'd be much obliged. -Hyrum -- uberSVN: Apache Subversion Made Easy http://www.uberSVN.com/
