"Bert Huijben" <b...@qqmail.nl> writes: >> -----Original Message----- >> From: Philip Martin [mailto:philip.mar...@wandisco.com] >> Sent: dinsdag 21 februari 2012 14:14 >> To: Daniel Shahaf >> Cc: dev@subversion.apache.org >> Subject: Re: APR hash order >> >> Daniel Shahaf <danie...@elego.de> writes: >> >> > Philip Martin wrote on Tue, Feb 21, 2012 at 12:32:43 +0000: >> >> The dumpfile order is more interesting. Although we don't specify the >> >> dumpfile order until now it has been repeatable, at least when using > the >> >> same executable/libraries. I can see that this repeatability is useful >> >> to an administrator. Rather than fixing the testsuite to ignore >> >> dumpfile order changes perhaps we should remove the random >> behaviour and >> >> continue to provide repeatable dumpfiles? This would involve using >> >> apr_hash_make_custom rather than apr_hash_make. I don't know >> whether >> > >> > Instead of apr_hash_make_custom(), couldn't we dump entries in >> directory >> > order instead? That makes the order a function of the repository mirror >> > dumped, rather than of the software version used. >> > >> > For FSFS dirs are stored in an svn_hash_write2() hash; for BDB they are >> > stored in a skel of node-rev skels; both of these structures are >> > naturally ordered, though in the former case we discard the order when >> > we parse the rep. >> >> That might be possible. There may be other hashes beyond the directory >> entries, I guess the properties associated with a node might be in hash >> order. Making the directory order repeatable only really makes sense if >> we end up with a dumpfile that is identical. > > I don't think this will really help. Implementing EditorV2 will break these > same tests, and probably a lot more that have similar assumptions on other > orderings.
Perhaps Ev2 will need testsuite changes, but I'm not really concerned with the testsuite here. What I'm interested in here is whether an admin can expect svnadmin dump -rN repo > dump.txt to produce exactly the same output when run twice. If the admin is running a dump multiple times does it matter if the checksum of dump.txt changes? -- uberSVN: Apache Subversion Made Easy http://www.uberSVN.com
