On Tue, Feb 7, 2012 at 10:55 PM, Greg Stein <gst...@gmail.com> wrote:
> That log message doesn't describe the change. You were already computing and
> passing a checksum.
>
> Maybe the bug was that you did not close TARGET to finalize the checksum
> computation?

I think that makes sense.  Looking at other receivers of
apply_textdelta, it appears they had either manually close the source
stream, but not the target stream.  I added something similar to the
shims in r1241976.

However, when I tried closing the target stream after the textdelta
was applied, I got an error that the file didn't exist.  My guess is
that txdelta_apply() is closing the target stream (though I couldn't
find documentation to that effect).  Why the checksum isn't getting
finalized is anybody's guess.

-Hyrum


-- 

uberSVN: Apache Subversion Made Easy
http://www.uberSVN.com/

Reply via email to