On Fri, Dec 2, 2011 at 7:04 PM, <hwri...@apache.org> wrote: > Author: hwright > Date: Fri Dec 2 18:04:14 2011 > New Revision: 1209610 > > URL: http://svn.apache.org/viewvc?rev=1209610&view=rev > Log: > Fix builds where SVN_DEBUG is not defined. > > * subversion/libsvn_subr/debug.c: > Don't build any of this file if SVN_DEBUG isn't defined. Callers don't have > access to it in that case, anyway.
For some reason, after this commit my *Release* build on Windows (VCE 2008) fails with: libsvn_subr.def : error LNK2001: unresolved external symbol svn_dbg__preamble libsvn_subr.def : error LNK2001: unresolved external symbol svn_dbg__print_props libsvn_subr.def : error LNK2001: unresolved external symbol svn_dbg__printf ..\..\..\Release\subversion\libsvn_subr\libsvn_subr-1.lib : fatal error LNK1120: 3 unresolved externals I've been trying to understand why, but I don't. Maybe something to do with preprocessors and linkers ... but my C compilation knowledge is lacking here :-). Is any of the other Windows devs seeing this? A Debug build still works, so if SVN_DEBUG is defined everything's ok. I guess that's also the reason why the buildbots don't see this problem (I guess they perform Debug-builds). -- Johan > Modified: > subversion/trunk/subversion/libsvn_subr/debug.c > > Modified: subversion/trunk/subversion/libsvn_subr/debug.c > URL: > http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_subr/debug.c?rev=1209610&r1=1209609&r2=1209610&view=diff > ============================================================================== > --- subversion/trunk/subversion/libsvn_subr/debug.c (original) > +++ subversion/trunk/subversion/libsvn_subr/debug.c Fri Dec 2 18:04:14 2011 > @@ -29,6 +29,9 @@ > #include "svn_types.h" > #include "svn_string.h" > > +/* We only build this code if SVN_DEBUG is defined. */ > +#ifdef SVN_DEBUG > + > #include "private/svn_debug.h" > > > @@ -111,3 +114,5 @@ svn_dbg__print_props(apr_hash_t *props, > SVN_DBG((" '%s' -> '%s'\n", name, val->data)); > } > } > + > +#endif > >
