On 11/05/2011 10:42 AM, Stefan Sperling wrote: >> So, yeah, maybe we should make UC2 the default and provide an >> --exclude-externals option. Anyone who's asking how to get a default of not >> committing dir externals along can simply be told: revision peg them. > > I don't think changing the current default behaviour is a good idea. > Changing the default behaviour is more likely to break existing > scripts than a new configuration option.
The patch as-is also changes the default behavior: file externals are now excluded by default, just like dir externals always were. > If a script wants to make sure it isn't affected by such settings it > should use --config-dir to use a known set of configuration files. +1 > But maybe there's a better way of handling this. > Instead of adding a new option into the configuration file, can't we > extend the svn:externals syntax to optionally specify whether an external > should be committed along with its parent by default? The way I see it, revision-pegging is exactly that way of marking an external as "don't commit to it", so I don't think we need a change in externals syntax. And once our thought experiment has reached that point of: revision pegged external should not be committed along -- then it's just a tiny step to simply commit all non-pegged externals by default. Can you argue up a case where one would want a non-revision-pegged external excluded from commit? I'm reluctant to take simply previous externals behavior as argument, because externals have always sucked so far. > Also, please do not get too side-tracked because of the discussion [...] I do have a tendency to get side-tracked indeed, good vs. perfect... Committed in r1198765. But let's continue discussing, this is not as smooth as I'd like it to be. ~Neels
signature.asc
Description: OpenPGP digital signature
