Stefan Sperling <s...@elego.de> writes: > On Tue, Nov 01, 2011 at 06:36:26PM +0000, Philip Martin wrote: >> Is sorting in C better than putting UNIQUE on the local_relpath column? > > I don't know. I don't mind either way. Let's pick whichever is faster. > > The notification/cancellation fix is needed in either case.
I think the cacellation change is wrong. This is happening inside an SQLite transaction. When the user cancels a delete operation during notification the cancel callback will return an svn_error_t causing the transaction to abort. That means that no change will have been made to the database. I don't see how postponing that abort until all the notifications have been made is an improvement. -- uberSVN: Apache Subversion Made Easy http://www.uberSVN.com
