On Mon, Oct 24, 2011 at 2:11 PM, Daniel Shahaf <d...@daniel.shahaf.name> wrote: > Hyrum K Wright wrote on Mon, Oct 24, 2011 at 14:01:20 -0500: >> On Mon, Oct 24, 2011 at 1:13 PM, Daniel Shahaf <d...@daniel.shahaf.name> >> wrote: >> > hwri...@apache.org wrote on Mon, Oct 24, 2011 at 17:48:07 -0000: >> >> Author: hwright >> >> Date: Mon Oct 24 17:48:06 2011 >> >> New Revision: 1188256 >> >> >> >> URL: http://svn.apache.org/viewvc?rev=1188256&view=rev >> >> Log: >> >> Create a struct to hold the ever-growing collection of Ev2 shim callbacks. >> >> >> >> * subversion/include/svn_delta.h >> >> (svn_delta_shim_callbacks_t, svn_delta_shim_callbacks_default): New. >> >> (svn_editor__insert_shims): Use the struct in place of individual >> >> params. >> >> >> > >> > svn_delta_shim_callbacks_dup()? >> >> I really hope this code never sees the light of a release. We can add >> that function if/when we need it. >> > > Then put it in include/private/ ?
gen-make.py complains loudly if a public header depends on a private one. > >> -Hyrum >> >> >> * subversion/libsvn_ra_svn/editorp.c, >> >> subversion/libsvn_ra_neon/commit.c, >> >> subversion/svnsync/main.c, >> >> subversion/svnrdump/dump_editor.c, >> >> subversion/libsvn_wc/diff_editor.c, >> >> subversion/libsvn_wc/update_editor.c, >> >> subversion/libsvn_wc/status.c, >> >> subversion/libsvn_client/repos_diff.c, >> >> subversion/libsvn_client/mergeinfo.c, >> >> subversion/libsvn_client/export.c, >> >> subversion/libsvn_ra_serf/commit.c, >> >> subversion/libsvn_repos/commit.c, >> >> subversion/libsvn_repos/dump.c: >> >> Use the new struct and update callers to the shim API. >> >> >> >> * subversion/libsvn_delta/compat.c >> >> (svn_delta_shim_callbacks_default): New. >> >> (svn_editor__insert_shims): Use the new datatype. >> > >> >> >> >> -- >> >> uberSVN: Apache Subversion Made Easy >> http://www.uberSVN.com/ > -- uberSVN: Apache Subversion Made Easy http://www.uberSVN.com/
