On Thu, Oct 13, 2011 at 07:18:50PM +0100, Philip Martin wrote: > Daniel Shahaf <d...@daniel.shahaf.name> writes: > > My reading of > > http://svn.apache.org/repos/asf/apr/apr/tags/0.9.0/include/apr.h.in > > http://svn.apache.org/repos/asf/apr/apr/tags/0.9.0/include/apr.hnw > > http://svn.apache.org/repos/asf/apr/apr/tags/0.9.0/include/apr.hw > > is that APR_HAS_THREADS is always defined. > > Then we would be relying on APR to do it. It's not the way all > preprocessor symbols are defined, for example svn_private_config.h > generally uses <nothing> rather than #define XXX 0 and APR does the same > for APR_IS_DEV_VERSION.
I also passed APR_HAS_THREADS as a boolean arg in some recent commits, inspired by danielsh's idea. But now I agree with philip that it's not good practice to do this. +1 on changing it.
