On Tue, Jun 28, 2011 at 22:30, Ivan Zhakov <i...@visualsvn.com> wrote: > On Tue, Jun 28, 2011 at 21:01, Greg Stein <gst...@gmail.com> wrote: >> On Tue, Jun 28, 2011 at 06:26, <i...@apache.org> wrote: >>> Author: ivan >>> Date: Tue Jun 28 10:26:47 2011 >>> New Revision: 1140512 >>> >>> URL: http://svn.apache.org/viewvc?rev=1140512&view=rev >>> Log: >>> Reduce memory used by processing PROPFIND requests for specfici >>> properties (not allprop). >>> >>> * subversion/mod_dav_svn/dav_svn.h >>> (dav_resource_private): Add SCRATCH_POOL member. I decided do not use >>> existing POOL, because it's unclear where it should be cleared or >>> destroyed. May be someone with better knowledge fix it in the future. >> > Hi, Greg! > > I was expecting your review and comments. Thanks! See my answers below. > >> No way, man. This is one of the most dangerous constructs possible. If >> other functions start to use ->scratch_pool, and clear it in the same >> fashion, then nobody can rely on using it for their own work. You >> simply cannot share a scratch pool through a structure where it might >> get cleared by *any* call to another mod_dav function. Hi Greg,
I made pool usage more clear in r1142663. Thanks for review. -- Ivan Zhakov
