How does this impact backward compat? If somebody was including just 'svn_wc.h' and expecting to get the contents of svn_version.h, their code will now not compile, yes? This is demonstrated by our own build breakage after r1132965.
(You mention a similar cleanup happened early in 1.7 development. I apologize if I'm digging up old laundry.) -Hyrum On Tue, Jun 7, 2011 at 7:09 AM, <rhuij...@apache.org> wrote: > Author: rhuijben > Date: Tue Jun 7 12:09:37 2011 > New Revision: 1132966 > > URL: http://svn.apache.org/viewvc?rev=1132966&view=rev > Log: > Remove #include "svn_version.h" from a number of public header files, to > reduce > build time in third party build environments and when switching between > branches. > > This file modifies in some build scenarios because it contains the version > number and version description texts. > > This change is similar to another recursive header include cleanup performed > early in Subversion 1.7 development. > > * subversion/include/svn_auth.h > * subversion/include/svn_client.h > * subversion/include/svn_delta.h > * subversion/include/svn_diff.h > * subversion/include/svn_repos.h > * subversion/include/svn_wc.h > (includes): Remove svn_version.h > > * subversion/libsvn_ra_svn/client.c > * subversion/svn/main.c > * subversion/svnlook/main.c > * subversion/svnsync/main.c > * subversion/svnversion/main.c > * tools/dev/svnraisetreeconflict/main.c > (includes): Add svn_version.h > > Modified: > subversion/trunk/subversion/include/svn_auth.h > subversion/trunk/subversion/include/svn_client.h > subversion/trunk/subversion/include/svn_delta.h > subversion/trunk/subversion/include/svn_diff.h > subversion/trunk/subversion/include/svn_repos.h > subversion/trunk/subversion/include/svn_wc.h > subversion/trunk/subversion/libsvn_ra_svn/client.c > subversion/trunk/subversion/svn/main.c > subversion/trunk/subversion/svnlook/main.c > subversion/trunk/subversion/svnsync/main.c > subversion/trunk/subversion/svnversion/main.c > subversion/trunk/tools/dev/svnraisetreeconflict/main.c > > Modified: subversion/trunk/subversion/include/svn_auth.h > URL: > http://svn.apache.org/viewvc/subversion/trunk/subversion/include/svn_auth.h?rev=1132966&r1=1132965&r2=1132966&view=diff > ============================================================================== > --- subversion/trunk/subversion/include/svn_auth.h (original) > +++ subversion/trunk/subversion/include/svn_auth.h Tue Jun 7 12:09:37 2011 > @@ -34,7 +34,6 @@ > > #include "svn_types.h" > #include "svn_config.h" > -#include "svn_version.h" > > #ifdef __cplusplus > extern "C" { > > Modified: subversion/trunk/subversion/include/svn_client.h > URL: > http://svn.apache.org/viewvc/subversion/trunk/subversion/include/svn_client.h?rev=1132966&r1=1132965&r2=1132966&view=diff > ============================================================================== > --- subversion/trunk/subversion/include/svn_client.h (original) > +++ subversion/trunk/subversion/include/svn_client.h Tue Jun 7 12:09:37 2011 > @@ -43,7 +43,6 @@ > #include "svn_string.h" > #include "svn_wc.h" > #include "svn_opt.h" > -#include "svn_version.h" > #include "svn_ra.h" > #include "svn_diff.h" > #include "svn_auth.h" > > Modified: subversion/trunk/subversion/include/svn_delta.h > URL: > http://svn.apache.org/viewvc/subversion/trunk/subversion/include/svn_delta.h?rev=1132966&r1=1132965&r2=1132966&view=diff > ============================================================================== > --- subversion/trunk/subversion/include/svn_delta.h (original) > +++ subversion/trunk/subversion/include/svn_delta.h Tue Jun 7 12:09:37 2011 > @@ -40,7 +40,6 @@ > #include "svn_types.h" > #include "svn_string.h" > #include "svn_io.h" > -#include "svn_version.h" > #include "svn_checksum.h" > > #ifdef __cplusplus > > Modified: subversion/trunk/subversion/include/svn_diff.h > URL: > http://svn.apache.org/viewvc/subversion/trunk/subversion/include/svn_diff.h?rev=1132966&r1=1132965&r2=1132966&view=diff > ============================================================================== > --- subversion/trunk/subversion/include/svn_diff.h (original) > +++ subversion/trunk/subversion/include/svn_diff.h Tue Jun 7 12:09:37 2011 > @@ -54,7 +54,6 @@ > > #include "svn_types.h" > #include "svn_io.h" /* for svn_stream_t */ > -#include "svn_version.h" > #include "svn_string.h" > > #ifdef __cplusplus > > Modified: subversion/trunk/subversion/include/svn_repos.h > URL: > http://svn.apache.org/viewvc/subversion/trunk/subversion/include/svn_repos.h?rev=1132966&r1=1132965&r2=1132966&view=diff > ============================================================================== > --- subversion/trunk/subversion/include/svn_repos.h (original) > +++ subversion/trunk/subversion/include/svn_repos.h Tue Jun 7 12:09:37 2011 > @@ -37,7 +37,6 @@ > #include "svn_delta.h" > #include "svn_fs.h" > #include "svn_io.h" > -#include "svn_version.h" > #include "svn_mergeinfo.h" > > > > Modified: subversion/trunk/subversion/include/svn_wc.h > URL: > http://svn.apache.org/viewvc/subversion/trunk/subversion/include/svn_wc.h?rev=1132966&r1=1132965&r2=1132966&view=diff > ============================================================================== > --- subversion/trunk/subversion/include/svn_wc.h (original) > +++ subversion/trunk/subversion/include/svn_wc.h Tue Jun 7 12:09:37 2011 > @@ -84,7 +84,6 @@ > #include "svn_delta.h" /* for svn_stream_t */ > #include "svn_opt.h" > #include "svn_ra.h" /* for svn_ra_reporter_t type */ > -#include "svn_version.h" > > #ifdef __cplusplus > extern "C" { > > Modified: subversion/trunk/subversion/libsvn_ra_svn/client.c > URL: > http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_svn/client.c?rev=1132966&r1=1132965&r2=1132966&view=diff > ============================================================================== > --- subversion/trunk/subversion/libsvn_ra_svn/client.c (original) > +++ subversion/trunk/subversion/libsvn_ra_svn/client.c Tue Jun 7 12:09:37 > 2011 > @@ -40,15 +40,18 @@ > #include "svn_path.h" > #include "svn_pools.h" > #include "svn_config.h" > -#include "svn_private_config.h" > #include "svn_ra.h" > -#include "../libsvn_ra/ra_loader.h" > #include "svn_ra_svn.h" > #include "svn_props.h" > #include "svn_mergeinfo.h" > +#include "svn_version.h" > + > +#include "svn_private_config.h" > > #include "private/svn_fspath.h" > > +#include "../libsvn_ra/ra_loader.h" > + > #include "ra_svn.h" > > #ifdef SVN_HAVE_SASL > > Modified: subversion/trunk/subversion/svn/main.c > URL: > http://svn.apache.org/viewvc/subversion/trunk/subversion/svn/main.c?rev=1132966&r1=1132965&r2=1132966&view=diff > ============================================================================== > --- subversion/trunk/subversion/svn/main.c (original) > +++ subversion/trunk/subversion/svn/main.c Tue Jun 7 12:09:37 2011 > @@ -51,6 +51,7 @@ > #include "svn_utf.h" > #include "svn_auth.h" > #include "svn_hash.h" > +#include "svn_version.h" > #include "cl.h" > #include "svn_cache_config.h" > > > Modified: subversion/trunk/subversion/svnlook/main.c > URL: > http://svn.apache.org/viewvc/subversion/trunk/subversion/svnlook/main.c?rev=1132966&r1=1132965&r2=1132966&view=diff > ============================================================================== > --- subversion/trunk/subversion/svnlook/main.c (original) > +++ subversion/trunk/subversion/svnlook/main.c Tue Jun 7 12:09:37 2011 > @@ -49,6 +49,7 @@ > #include "svn_opt.h" > #include "svn_props.h" > #include "svn_diff.h" > +#include "svn_version.h" > #include "svn_xml.h" > > #include "private/svn_cmdline_private.h" > > Modified: subversion/trunk/subversion/svnsync/main.c > URL: > http://svn.apache.org/viewvc/subversion/trunk/subversion/svnsync/main.c?rev=1132966&r1=1132965&r2=1132966&view=diff > ============================================================================== > --- subversion/trunk/subversion/svnsync/main.c (original) > +++ subversion/trunk/subversion/svnsync/main.c Tue Jun 7 12:09:37 2011 > @@ -32,6 +32,7 @@ > #include "svn_utf.h" > #include "svn_subst.h" > #include "svn_string.h" > +#include "svn_version.h" > > #include "private/svn_opt_private.h" > #include "private/svn_ra_private.h" > > Modified: subversion/trunk/subversion/svnversion/main.c > URL: > http://svn.apache.org/viewvc/subversion/trunk/subversion/svnversion/main.c?rev=1132966&r1=1132965&r2=1132966&view=diff > ============================================================================== > --- subversion/trunk/subversion/svnversion/main.c (original) > +++ subversion/trunk/subversion/svnversion/main.c Tue Jun 7 12:09:37 2011 > @@ -25,6 +25,7 @@ > #include "svn_wc.h" > #include "svn_utf.h" > #include "svn_opt.h" > +#include "svn_version.h" > > #include "svn_private_config.h" > > > Modified: subversion/trunk/tools/dev/svnraisetreeconflict/main.c > URL: > http://svn.apache.org/viewvc/subversion/trunk/tools/dev/svnraisetreeconflict/main.c?rev=1132966&r1=1132965&r2=1132966&view=diff > ============================================================================== > --- subversion/trunk/tools/dev/svnraisetreeconflict/main.c (original) > +++ subversion/trunk/tools/dev/svnraisetreeconflict/main.c Tue Jun 7 > 12:09:37 2011 > @@ -40,6 +40,7 @@ > #include "svn_utf.h" > #include "svn_path.h" > #include "svn_opt.h" > +#include "svn_version.h" > > #include "private/svn_wc_private.h" > > > >
