> -----Original Message----- > From: Stefan Küng [mailto:tortoise...@gmail.com] > Sent: zondag 29 mei 2011 14:41 > To: Bert Huijben > Cc: 'Greg Stein'; 'Subversion Development'; 'Daniel Shahaf' > Subject: Re: Windows build, nonexistent functions > > On 29.05.2011 14:25, Bert Huijben wrote: > > >> I've adjusted the TSVN build to remove those functions from the > >> extractor.py output. So it's not a big deal for me. > >> But I'm still wondering whether the Windows build for the svn client > >> works. Can anyone here try it? > >> If it works, those functions could stay there so you don't have to track > >> them down again once you need them. > > > > We only call extractor.py on the header files referenced in 'msvc-export =' > > lines of build.conf. > > > > All the functions referenced in this mail thread are library private on a > > normal Windows build. > > > > The Windows-RA buildbot uses a shared library build, so its build would > have > > been broken for more than a year, if this would have been a problem. > > > > Are you seeing this problem in a custom build? ;) > > Forgot about the build.conf file. Sorry about the noise.
Removing undefined functions from the headers is a good thing, especially if they would be there in a release, so no problem + thanks! But leaving them disabled with a documented reason shouldn't be a problem. Bert