On May 23, 2011 12:48 PM, "Julian Foad" <julian.f...@wandisco.com> wrote: > > Greg Stein wrote: > > On May 23, 2011 11:57 AM, <julianf...@apache.org> wrote: > > >... > > was 40 hex digits. */ > > > - if (finfo->filetype == APR_REG && strlen(path) == 40) > > > + if (finfo->filetype == APR_REG > > > + && (strlen(svn_dirent_basename(abspath, pool)) > > > + == > > > > On my phone, so I can't tell, but ... can basename() take NULL for the pool? > > Yes it can. You thinking we should pass NULL and so squeeze a few more > microseconds out of the developer-only upgrade scenario?
The basename is completely transient, so there's no reason to alloc and copy. That said: you're right. It was a reflexive suggestion, which is kinda moot given the larger context. Cheers, -g
