> -----Original Message-----
> From: Branko Čibej [mailto:br...@xbc.nu] On Behalf Of Branko Cibej
> Sent: woensdag 18 mei 2011 21:25
> To: dev@subversion.apache.org
> Subject: Re: svn commit: r1103749 -
> /subversion/trunk/subversion/libsvn_wc/wc_db_wcroot.c
> 
> On 17.05.2011 12:37, Stefan Fuhrmann wrote:
> > On 17.05.2011 10:11, Greg Stein wrote:
> >> On May 16, 2011 10:29 AM,<stef...@apache.org>  wrote:
> >>> Author: stefan2
> >>> Date: Mon May 16 14:28:45 2011
> >>> New Revision: 1103749
> >>>
> >>> URL: http://svn.apache.org/viewvc?rev=1103749&view=rev
> >>> Log:
> >>> SVN status will try to read the .format file for every folder in
> >>> the working copy.  That is very expensive, so do a stat call
> >>> to check whether the .format file exists - which it won't for
> >>> wc-ng w/cs.
> >> Is this true for both Windows and unix-ish?
> > AFAICT, this is true for both Windows and Unix.
> > Even if a failed file_open is equivalent to a stat,
> > we would still create a locale-dependent svn_error_t
> > object and that is expensive (at least not for free).
> 
> Wait -- creating an svn_error_t is more expensive than the extra stat?

It is not an extra stat. It is an 'instead' stat.

1.7+ will just read the db as the format file isn't there in all those folders 
that don't exist.

        Bert

Reply via email to