danie...@apache.org wrote on Wed, May 18, 2011 at 13:22:30 -0000:
> Author: danielsh
> Date: Wed May 18 13:22:29 2011
> New Revision: 1124254
>
> URL: http://svn.apache.org/viewvc?rev=1124254&view=rev
> Log:
> cache_inprocess.c =~ s/assert/SVN_ERR_ASSERT/
>
> * subversion/libsvn_subr/cache-inprocess.c
> (move_page_to_front): Change return type and s/assert/SVN_ERR_ASSERT/.
> (inprocess_cache_t, inprocess_cache_get, inprocess_cache_set,
> inprocess_cache_get_partial, inprocess_cache_set_partial):
> Track change.
>
> Modified:
> subversion/trunk/subversion/libsvn_subr/cache-inprocess.c
>
> Modified: subversion/trunk/subversion/libsvn_subr/cache-inprocess.c
> URL:
> http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_subr/cache-inprocess.c?rev=1124254&r1=1124253&r2=1124254&view=diff
> ==============================================================================
> --- subversion/trunk/subversion/libsvn_subr/cache-inprocess.c (original)
> +++ subversion/trunk/subversion/libsvn_subr/cache-inprocess.c Wed May 18
> 13:22:29 2011
> @@ -148,11 +148,11 @@ insert_page(inprocess_cache_t *cache,
>
> /* If PAGE is in the circularly linked list (eg, its NEXT isn't NULL),
> * move it to the front of the list. */
> -static void
> +static svn_error_t *
> move_page_to_front(inprocess_cache_t *cache,
> struct cache_page *page)
> {
> - assert(page != cache->sentinel);
> + SVN_ERR_ASSERT(page != cache->sentinel);
>
> if (! page->next)
> return;
This broke two bots (so far):
[[[
16:28:27 < subversion-bot> build #4181 of svn-slik-w2k3-x64-local is complete:
Failure [failed Test
fsfs+local Test Bindings] Build details are at
http://ci.apache.org/builders/svn-slik-w2k3-x64-local/builds/4181
blamelist: danielsh
16:28:58 < subversion-bot> build #4120 of svn-debian-x64-32-shared-gcc is
complete: Failure [failed
Test fsfs+ra_svn] Build details are at
http://ci.apache.org/builders/svn-debian-x64-32-shared-gcc/builds/4120
blamelist: danielsh
]]]
I'd be happy if whoever added that assert() could look into that... (but
if not I'm happy to try and have a look --- once I've become familiar
with this part of the code)
