I wasn't really concerned about including dead code, so I didn't bother with that.
But... if we are or should be concerned, then I would recommend using #ifdef SVN_DEBUG for the guard. That will keep it compiling for "us" so that we can avoid bitrot problems. Cheers, -g On Sat, May 7, 2011 at 03:54, Daniel Shahaf <d...@daniel.shahaf.name> wrote: > Shouldn't we put #ifdef guards around editor.c to prevent it from being > compiled? Nothing uses that code right now. > > gst...@apache.org wrote on Sat, May 07, 2011 at 06:53:25 -0000: >> Author: gstein >> Date: Sat May 7 06:53:24 2011 >> New Revision: 1100466 >> >> URL: http://svn.apache.org/viewvc?rev=1100466&view=rev >> Log: >> We don't want to publish the svn_editor API for 1.7. Move the header >> into the private area. >> >> * subversion/include/svn_editor.h: >> (): moved to ... >> >> * subversion/include/private/svn_editor.h: >> (): ... here >> >> * subversion/libsvn_delta/editor.c: >> (): adjust svn_editor.h include to account for the move >> >> Added: >> subversion/trunk/subversion/include/private/svn_editor.h >> - copied unchanged from r1100458, >> subversion/trunk/subversion/include/svn_editor.h >> Removed: >> subversion/trunk/subversion/include/svn_editor.h >> Modified: >> subversion/trunk/subversion/libsvn_delta/editor.c >> >> Modified: subversion/trunk/subversion/libsvn_delta/editor.c >> URL: >> http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_delta/editor.c?rev=1100466&r1=1100465&r2=1100466&view=diff >> ============================================================================== >> --- subversion/trunk/subversion/libsvn_delta/editor.c (original) >> +++ subversion/trunk/subversion/libsvn_delta/editor.c Sat May 7 06:53:24 >> 2011 >> @@ -26,7 +26,8 @@ >> #include "svn_types.h" >> #include "svn_error.h" >> #include "svn_pools.h" >> -#include "svn_editor.h" >> + >> +#include "private/svn_editor.h" >> >> >> struct svn_editor_t >> >> >
