Is this a performance issue that must be solved for 1.7? I always figured changelist were on the edge case. On Apr 5, 2011 1:29 PM, <hwri...@apache.org> wrote: > Author: hwright > Date: Tue Apr 5 20:28:50 2011 > New Revision: 1089206 > > URL: http://svn.apache.org/viewvc?rev=1089206&view=rev > Log: > Add depth and changelist filter parameters to svn_wc__db_op_set_changelist(). > These aren't implemented (other than depth = empty). This is a preliminary > step in removing the node walker from the changelist setting code. > > * subversion/libsvn_wc/adm_ops.c > (svn_wc_set_changelist2): Update caller. > > * subversion/libsvn_wc/wc_db.c > (svn_wc__db_op_set_changelist): Add changelist and depth params. > > * subversion/libsvn_wc/wc_db.h > (svn_wc__db_op_set_changelist): Same. > > Modified: > subversion/trunk/subversion/libsvn_wc/adm_ops.c > subversion/trunk/subversion/libsvn_wc/wc_db.c > subversion/trunk/subversion/libsvn_wc/wc_db.h > > Modified: subversion/trunk/subversion/libsvn_wc/adm_ops.c > URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_wc/adm_ops.c?rev=1089206&r1=1089205&r2=1089206&view=diff > ============================================================================== > --- subversion/trunk/subversion/libsvn_wc/adm_ops.c (original) > +++ subversion/trunk/subversion/libsvn_wc/adm_ops.c Tue Apr 5 20:28:50 2011 > @@ -2198,7 +2198,7 @@ svn_wc_set_changelist2(svn_wc_context_t > > /* Set the changelist. */ > SVN_ERR(svn_wc__db_op_set_changelist(wc_ctx->db, local_abspath, changelist, > - scratch_pool)); > + NULL, svn_depth_empty, scratch_pool)); > > /* And tell someone what we've done. */ > if (notify_func) > > Modified: subversion/trunk/subversion/libsvn_wc/wc_db.c > URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_wc/wc_db.c?rev=1089206&r1=1089205&r2=1089206&view=diff > ============================================================================== > --- subversion/trunk/subversion/libsvn_wc/wc_db.c (original) > +++ subversion/trunk/subversion/libsvn_wc/wc_db.c Tue Apr 5 20:28:50 2011 > @@ -3406,8 +3406,11 @@ svn_error_t * > svn_wc__db_op_set_changelist(svn_wc__db_t *db, > const char *local_abspath, > const char *changelist, > + const apr_hash_t *changelists, > + svn_depth_t depth, > apr_pool_t *scratch_pool) > { > + svn_wc__db_txn_callback_t txn_func; > svn_wc__db_wcroot_t *wcroot; > const char *local_relpath; > > @@ -3417,6 +3420,17 @@ svn_wc__db_op_set_changelist(svn_wc__db_ > db, local_abspath, scratch_pool, scratch_pool)); > VERIFY_USABLE_WCROOT(wcroot); > > + switch (depth) > + { > + case svn_depth_empty: > + txn_func = set_changelist_txn; > + break; > + > + default: > + /* ### This is only implemented for depth = empty right now. */ > + NOT_IMPLEMENTED(); > + } > + > SVN_ERR(svn_wc__db_with_txn(wcroot, local_relpath, set_changelist_txn, > (void *) changelist, scratch_pool)); > > > Modified: subversion/trunk/subversion/libsvn_wc/wc_db.h > URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_wc/wc_db.h?rev=1089206&r1=1089205&r2=1089206&view=diff > ============================================================================== > --- subversion/trunk/subversion/libsvn_wc/wc_db.h (original) > +++ subversion/trunk/subversion/libsvn_wc/wc_db.h Tue Apr 5 20:28:50 2011 > @@ -1203,6 +1203,8 @@ svn_error_t * > svn_wc__db_op_set_changelist(svn_wc__db_t *db, > const char *local_abspath, > const char *changelist, > + const apr_hash_t *changelists, > + svn_depth_t depth, > apr_pool_t *scratch_pool); > > > >
