On Mar 14, 2011 7:32 PM, <hwri...@apache.org> wrote: > > Author: hwright > Date: Mon Mar 14 19:32:04 2011 > New Revision: 1081528 > > URL: http://svn.apache.org/viewvc?rev=1081528&view=rev > Log: > Fix the svnversion test 1 failure introduced in r1081510. This involves > exposing the wc_db txn handler to the larger library, rather than just > wc_db.c. > > One of the pristine handling functions was using an SQLite txn, which > couldn't be nested. This change allows that txn to be nested.
I would like to state this explicitly: let's not expose SQL transactions in the wc_db.h interface. This change keeps it within wc_db, but I would hate to see it go further. I think that would be a horrible breakage of encapsulation. I recognize we need to grow the scope of transactions for speed purposes, but let's do it in a way based on semantics rather than implementation. For example: to speed checkout, we could have an API to add a complete directory of nodes, rather than an API to start/end a txn across those single additions. Cheers, -g
