Barry Scott <ba...@barrys-emacs.org> writes:

> On 10 Jan 2011, at 03:59, Daniel Shahaf wrote:
>
>> Are the typedefs for SVN_FILESIZE_T_FMT and APR_OFF_T_FMT correct?
>
> No APR_OFF_T_FMT is wrong. Its "%lld" but needs to be APR_INT64_T_FMT so
> that the apr_xxxprintf code will process it. It turns out that %lld is only 
> half handled
> and that leads to the crash.
>
> I applied this patch to get things working for me on Mac OS X 10.6 using the 
> 10.6 SDK.
>
> --- ./apr/configure~    2011-02-27 11:37:40.000000000 +0000
> +++ ./apr/configure     2011-02-27 11:37:40.000000000 +0000

To get this into APR you need to patch configure.in, not configure as
that is a generated file.

> @@ -29986,7 +29986,7 @@
>      *apple-darwin10.*)
>          # off_t is a long long, but long == long long
>          if test "$ac_cv_sizeof_long" = "$ac_cv_sizeof_long_long"; then
> -            off_t_fmt='#define APR_OFF_T_FMT "lld"'
> +            off_t_fmt='#define APR_OFF_T_FMT APR_INT64_T_FMT'
>          fi
>          ;;
>      esac
>
> The APR folks will need to fix their configure for Mac.

Looking at the log:

http://svn.apache.org/viewvc/apr/apr/trunk/configure.in?view=log

I think r1050391 makes the change you are advocating, but it was
reverted in r1051230.

-- 
Philip

Reply via email to