On Fri, Feb 25, 2011 at 02:06:59PM +0200, Daniel Shahaf wrote: > It was discussed a few months ago, conclusion was that the casts are > necessary because they don't happen automatically for varargs functions > (like apr_pstrcat()). >
Yes, see these, and other messages from the same thread, for related discussion: http://svn.haxx.se/dev/archive-2010-10/0053.shtml http://svn.haxx.se/dev/archive-2010-10/0061.shtml http://svn.haxx.se/dev/archive-2010-10/0071.shtml > Greg Stein wrote on Fri, Feb 25, 2011 at 07:01:38 -0500: > > What?! ... what is this? I've never seen "missing sentinel". This just > > seems to complicate the code for the sake of a compiler. And one that > > historically has not been a problem for us. That's because NULL is defined differenly on different systems. You don't see the warnings, but I do.
