> -----Original Message-----
> From: Joe Swatosh [mailto:joe.swat...@gmail.com]
> Sent: woensdag 9 februari 2011 23:43
> To: dev@subversion.apache.org
> Cc: rhuij...@apache.org
> Subject: Re: svn commit: r1068863 -
> /subversion/trunk/build/generator/gen_msvc_dsp.py
> 
> On Wed, Feb 9, 2011 at 4:32 AM,  <rhuij...@apache.org> wrote:
> > Author: rhuijben
> > Date: Wed Feb  9 12:32:57 2011
> > New Revision: 1068863
> >
> > URL: http://svn.apache.org/viewvc?rev=1068863&view=rev
> > Log:
> > Following up on r1034362, fix generating the Visual C++ 6.0 style
> project
> > and workspace files. Visual C++ 6.0 is no longer supported by
> Microsoft,
> > but is still the default compiler used for Windows support by the Apr
> and
> > Httpd projects.
> >
> > * build/generator/gen_msvc_dsp.py
> >  (write_project): Take template from the right folder.
> >  (write): Fetch sql header dependencies.
> >
> 
> Hi Bert,
> Thanks! I get much further, but I also needed this to build:
> 
> Index: subversion/include/svn_types.h
> ===================================================================
> --- subversion/include/svn_types.h      (revision 1069119)
> +++ subversion/include/svn_types.h      (working copy)
> @@ -29,6 +29,7 @@
> 
>  /* ### this should go away, but it causes too much breakage right now
> */
>  #include <stdlib.h>
> +#include <limits.h>  /* for ULONG_MAX */

I think we should use one of the apr defines instead. Leaving this for
somebody else to fix.

> 
>  #include <apr.h>         /* for apr_size_t, apr_int64_t, ... */
>  #include <apr_errno.h>   /* for apr_status_t */
> Index: build/generator/templates/svn_config.dsp.ezt
> ===================================================================
> --- build/generator/templates/svn_config.dsp.ezt        (revision
> 1069119)
> +++ build/generator/templates/svn_config.dsp.ezt        (working copy)
> @@ -75,7 +75,7 @@
>  InputPath=..\..\subversion\svn_private_config.hw
> 
>  "..\..\subversion\svn_private_config.h" : $(SOURCE) "$(INTDIR)"
> "$(OUTDIR)"
> -       copy ..\..\subversion\svn_private_config.hw
> ..\..\subversion\svn_private_config.h > nul
> +       copy ..\..\..\subversion\svn_private_config.hw
> ..\..\..\subversion\svn_private_config.h > nul
> 
>  # End Custom Build

Fixed in r1069335. Can you confirm that this patch works for you?

        Bert

Reply via email to